lsp-rust: Append --no-run flag for debugging #4907
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
rust
documentation
client
Change the logic of lsp-rust-analyzer-debug to append --no-run when it's not already in cargo-args, not the other way round. The result is used only for obtaining the compiler-artifact, no need to run the tests to obtain it.
Rutherther
force-pushed
the
fix/lsp-rust-test-no-run
branch
from
0aa6ede to
dbda7ad
Compare
jcs090218
approved these changes
Nov 9, 2025
Member
|
The logic sounds correct to me. Thank you for fixing this! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For me the tests were always being ran when Clicking on "Debug" button on a test in a rust file. I have gone over the logic and I am pretty confident that the condition here is wrong as it seems to me it should append --no-run only if it's not already present. This is to prevent having two --no-run flags that lead to an error
error: the argument '--no-run' cannot be used multiple times.Change the logic of lsp-rust-analyzer-debug to append --no-run when it's not already in cargo-args, not the other way round. The result is used only for obtaining the compiler-artifact, no need to run the tests to obtain it.